Attention is currently required from: neels, laforge, pespin, dexter.

View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 17: gsm0808_sc_cfg_from_modes() and

    added "_amr"

    Done

• File src/gsm/gsm0808_utils.c:

  • Patch Set #1, Line 1659: uint8_t gsm0808_sc_cfg_get_best_modes(uint16_t s15_s0, bool full_rate)

    makes sense, yes

    actually "best" refers to the "best Sn combination", not the highest rate. For example, S1 is considered better than S0 and S2 thru S9, because it has a range of different rates, etc

• File src/gsm/gsm0808_utils.c:

  • Patch Set #2, Line 1612: if (s_modes && ((s_modes & modes) == s_modes))

    it is possible, for example some modes are disabled for HR, […]

    Done

  • Patch Set #2, Line 1635: if (!(s15_s0 & s_bit))

    thanks, nice catch.

    Done

To view, visit change 29475. To unsubscribe, or for help writing mail filters, visit settings.