Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email ) Change subject: ggsn: Introduce test TC_pdp4(6)_act_deact_mtu ...................................................................... Patch Set 3: (3 comments) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/9d88e1e9_a67c4... : PS3, Line 248: f_vty_transceive(GGSNVTY, "apn internet");

"apn internet" is in "all" and "v4_only" configs, see the confmerge files here: […] Hmm I copied this from f_vty_set_gpdu_txseq(), which seems to be executed on all tests, are you sure about what you say? Maybe it needs to be fixed there too?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/c1b0d58b_be7f4... : PS3, Line 2360: execute(TC_pdp4_act_deact_mtu());

wrap in `if (m_ggsn_impl == GGSN_IMPL_OSMOCOM) {`, and same below for `TC_pdp46_act_deact_mtu`, sinc […] the test is expected to be run for open5gs too (it supports sending MTU), but it's true I need to wrap the vty functions in GGSN_IMPL_OSMOCOM.

File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/80fc9502_4f125... : PS3, Line 1229:

unrelated change Acknowledged

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2ceb76a3a07b44f69937c9f5a040482320bca377 Gerrit-Change-Number: 38469 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 09:01:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de>