Attention is currently required from: osmith.

View Change

3 comments:

• File ggsn_tests/GGSN_Tests.ttcn:

  • Patch Set #3, Line 248: f_vty_transceive(GGSNVTY, "apn internet");

    "apn internet" is in "all" and "v4_only" configs, see the confmerge files here: […]

    Hmm I copied this from f_vty_set_gpdu_txseq(), which seems to be executed on all tests, are you sure about what you say?
    Maybe it needs to be fixed there too?

  • Patch Set #3, Line 2360: execute(TC_pdp4_act_deact_mtu());

    wrap in `if (m_ggsn_impl == GGSN_IMPL_OSMOCOM) {`, and same below for `TC_pdp46_act_deact_mtu`, sinc […]

    the test is expected to be run for open5gs too (it supports sending MTU), but it's true I need to wrap the vty functions in GGSN_IMPL_OSMOCOM.

• File library/GTPv1C_Templates.ttcn:

  • Patch Set #3, Line 1229:

    unrelated change

    Acknowledged

To view, visit change 38469. To unsubscribe, or for help writing mail filters, visit settings.