Attention is currently required from: dexter, fixeria, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email ) Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io ...................................................................... Patch Set 4: (5 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/d7843810_68ce3add PS4, Line 1047: * \param[in] msg message buffer that holds the data to be send. Done https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/b60c709c_b5cddd7c PS4, Line 1520: .from_addr = (struct osmo_sockaddr *) saddr, but not const... we need to de-constify it, as 'struct osmo_rtp_msg_ctx' has a non-const from_addr member. https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/0568d840_72e84b46 PS4, Line 1696: if ((end->rtp && osmo_iofd_get_fd(end->rtp) != -1) || I originally did not have that check in place and it created problems (I think a crash). I don't recall the details. In any case, I'm just translating the old code with its -1 check to osmo_io. Anything else would be outside of the scope of this patch. The smaller such a patch is, and the less it changes the existing code, the better. File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e178a3da_f902f6c6 PS4, Line 526: goto out_free_v4; osmo_iofd_free() includes both closing and unregistering. This is documented in the omsmo_iofd documentation, and the code even has a comment below at the goto label that explicitly explains/states this. File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/385b76a2_6a1da5ee PS4, Line 661: uint8_t *buf = msgb_data(msg); Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a Gerrit-Change-Number: 36363 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Mar 2024 11:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment