Attention is currently required from: laforge, manawyrm, pespin, tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email ) Change subject: Add option to automatically reset RIFO on underrun/overflow ...................................................................... Patch Set 5: (3 comments) File src/octoi/e1oip.c: https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/0535f333_57d548f7 PS4, Line 278: int32_t d = fn32+i - iline->e1t.rifo.next_out_fn;

missing space between "fn32+i". […] fixed the missing space the wraparound is intended here (fn32 and netx_out_fn) are both 32 bits unsigned. the result is always the positive delay.

https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/5f2d8b2d_c7a5a45a PS4, Line 279: iline->e1t.delay += d;

do you account for overflow/wrapround here? the sum of delays (40000 measurements * maximum delay) is far below the range of 32 bits.

File src/octoi/frame_rifo.c: https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/aec8c2e8_9de892ad PS4, Line 111: {

wrong place for "{" char. This is not part of my patch (see latest patchset).

-- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id7ccbfbdb288990c01f185dec79a1022a68b4748 Gerrit-Change-Number: 34554 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account@tbspace.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: manawyrm <osmocom.account@tbspace.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 17:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment