Attention is currently required from: laforge, manawyrm, pespin, tnt.

View Change

3 comments:

• File src/octoi/e1oip.c:

  • Patch Set #4, Line 278: int32_t d = fn32+i - iline->e1t.rifo.next_out_fn;

    missing space between "fn32+i". […]

    fixed the missing space
    the wraparound is intended here (fn32 and netx_out_fn) are both 32 bits unsigned. the result is always the positive delay.

  • Patch Set #4, Line 279: iline->e1t.delay += d;

    do you account for overflow/wrapround here?

    the sum of delays (40000 measurements * maximum delay) is far below the range of 32 bits.

• File src/octoi/frame_rifo.c:

  • Patch Set #4, Line 111: {

    wrong place for "{" char.

    This is not part of my patch (see latest patchset).

To view, visit change 34554. To unsubscribe, or for help writing mail filters, visit settings.