Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email ) Change subject: mobile: init/deinit GAPK I/O based on CC transaction events ...................................................................... Patch Set 3: (2 comments) Patchset: PS3:

I still have the feeling you are attempting too many changes in this single commit, but ok. Those are all related changes. I would prefer to spend more time fixing bugs and implementing the missing features, rather than splitting every second patch here onto 10 smaller ones with "this is a preparation patch for ...." or "this will be used by upcoming patch".

File src/host/layer23/include/osmocom/bb/mobile/tch.h: https://gerrit.osmocom.org/c/osmocom-bb/+/35579/comment/35316314_212b420e PS3, Line 8: bool voice_or_data; /* voice (true) or data (false) */

please name it "voice" or "is_voice". […] "totally misleading" sounds totally subjective to me :P But ok.

-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b Gerrit-Change-Number: 35579 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jan 2024 10:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment