Attention is currently required from: pespin.
2 comments:
Patchset:
I still have the feeling you are attempting too many changes in this single commit, but ok.
Those are all related changes. I would prefer to spend more time fixing bugs and implementing the missing features, rather than splitting every second patch here onto 10 smaller ones with "this is a preparation patch for ...." or "this will be used by upcoming patch".
File src/host/layer23/include/osmocom/bb/mobile/tch.h:
Patch Set #3, Line 8: bool voice_or_data; /* voice (true) or data (false) */
please name it "voice" or "is_voice". […]
"totally misleading" sounds totally subjective to me :P But ok.
To view, visit change 35579. To unsubscribe, or for help writing mail filters, visit settings.