Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569 ) Change subject: hlr: add imsi unknown cause test case ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/a56ba627_d17cd... PS1, Line 155: imsi unknown cause imsi-unknown This syntax is not valid anymore, this is what we have in the VTY: reject-cause (not-found|no-proxy) (imsi-unknown|illegal-ms|...) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/cdf6c947_e7eff... PS1, Line 983: f_TC_ul_unknown_imsi_roaming_not_allowed I am confused reading this again: * the commit message says "add imsi unknown cause test case", * in `f_init_vty()` you set cause to `imsi-unknown` (for all TCs), * but the test case is called `unknown_imsi_roaming_not_allowed`. Is it `imsi-unknown` or `roaming-not-allowed` after all? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Sun, 26 Mar 2023 12:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment