Attention is currently required from: lynxis lazus.

Patch set 1:Code-Review -1

View Change

2 comments:

• File hlr/HLR_Tests.ttcn:

  • Patch Set #1, Line 155: imsi unknown cause imsi-unknown

    This syntax is not valid anymore, this is what we have in the VTY:

      reject-cause (not-found|no-proxy) (imsi-unknown|illegal-ms|...)

  • Patch Set #1, Line 983: f_TC_ul_unknown_imsi_roaming_not_allowed

    I am confused reading this again:

    • the commit message says "add imsi unknown cause test case",
    • in `f_init_vty()` you set cause to `imsi-unknown` (for all TCs),
    • but the test case is called `unknown_imsi_roaming_not_allowed`.

    Is it `imsi-unknown` or `roaming-not-allowed` after all?

To view, visit change 27569. To unsubscribe, or for help writing mail filters, visit settings.