Attention is currently required from: jolly, fixeria, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )
Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps.
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/f587d582_2af9ccc2
PS2, Line 26: gsmtap-category
If you really think I should, I can remove the
"gsmtap-" prefix from commands (I actually prefer the […]
tbh, I don't
get the "sapi" vs "category" difference here.
IMHO, calling it gsmtap-sapi only makes sense if we use the exact same syntax/naming as in
osmo-bts, where indeed as fixeria points out it was introduced to match the proprietary
DSP PHY intrface "SAPI" value.
And if we're not keeping it syntacticall identical to osmo-bts, then there's no
need to call the circuit switched part "sapi" and the GPRS side
"category"?
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/31108
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839
Gerrit-Change-Number: 31108
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 11:52:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment