Attention is currently required from: jolly, fixeria, pespin.

Patch set 3:Code-Review +1

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 26: gsmtap-category

    If you really think I should, I can remove the "gsmtap-" prefix from commands (I actually prefer the […]

    tbh, I don't get the "sapi" vs "category" difference here.

    IMHO, calling it gsmtap-sapi only makes sense if we use the exact same syntax/naming as in osmo-bts, where indeed as fixeria points out it was introduced to match the proprietary DSP PHY intrface "SAPI" value.

    And if we're not keeping it syntacticall identical to osmo-bts, then there's no need to call the circuit switched part "sapi" and the GPRS side "category"?

To view, visit change 31108. To unsubscribe, or for help writing mail filters, visit settings.