Attention is currently required from: laforge, daniel.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32758 )

Change subject: osmo_io: Improve handling of segmentation_cb ......................................................................

Patch Set 3:

(1 comment)

File include/osmocom/core/osmo_io.h:

https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/db6e1aee_7036377f PS3, Line 46: * Needs to return the size of the next segment. If it returns

The user should be concerned with sending or receiving protocol-level messages, and not be botered with TCP stream segmentation.

Agree with this. However, I wonder whether doing all this in osmo_io is the right place to do it, or rather keep this simpler and move segmentation one layer up (creating a new layer if needed).

I'm not saying this is wrong, just sharing my concerns. In any case, I think the segmentation_cb documentation should be improved, since at leas to me it's not clearer how this works without having to look deeply at the code.