Attention is currently required from: laforge, daniel.

View Change

1 comment:

• File include/osmocom/core/osmo_io.h:

  • Patch Set #3, Line 46: * Needs to return the size of the next segment. If it returns

    The user should be concerned with sending or receiving protocol-level messages, and not be botered with TCP stream segmentation.

    Agree with this. However, I wonder whether doing all this in osmo_io is the right place to do it, or rather keep this simpler and move segmentation one layer up (creating a new layer if needed).

    I'm not saying this is wrong, just sharing my concerns. In any case, I think the segmentation_cb documentation should be improved, since at leas to me it's not clearer how this works without having to look deeply at the code.

To view, visit change 32758. To unsubscribe, or for help writing mail filters, visit settings.