Attention is currently required from: neels, laforge, daniel.

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 )

Change subject: Add support for multiple APN profiles for subscriber data ......................................................................

Patch Set 10:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/c0eb2ff2_1c1f9fff PS7, Line 11: This violates the spec

spec reference please? […]

No. The spec which this is about. I haven't found it again. Sorry.

File include/osmocom/hlr/hlr_ps.h:

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/a3d0bea4_252a9fac PS9, Line 23: #pragma once

This file is never included anywhere. […]

Done

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/839c24b5_ff44e25a PS9, Line 32: struct {

Now sure if an anonymous struct as top level in a header file makes sense? […]

Done

File src/hlr_vty.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/1f866ebb_ad3d3a27 PS9, Line 252: info->apn_enc = (uint8_t *) talloc_strdup(g_hlr, apn_name);

This is actually wrong since you simply copy the profile info over in the GSUP message. […]

Done