Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email )

Change subject: tls: fix broken certificate hostname verification ......................................................................

Patch Set 1:

(1 comment)

File src/osmo_tls.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/42849/comment/88c29c57_b0d358d3?usp... : PS1, Line 529: sess->tls_hostname = client->tls_hostname; can client be freed here somehow while sess keeps being valid and hence sess->tls_hostname ends up pointing to a freed string? I'd rather do a talloc_strdrup() here to make the code more robust.