Attention is currently required from: fixeria.
View Change
1 comment:
File src/osmo_tls.c:
Patch Set #1, Line 529: sess->tls_hostname = client->tls_hostname;
can client be freed here somehow while sess keeps being valid and hence sess->tls_hostname ends up pointing to a freed string?
I'd rather do a talloc_strdrup() here to make the code more robust.
To view, visit change 42849. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: If64950a698bfcfbf556a37ef1be3e68abc124384
Gerrit-Change-Number: 42849
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jun 2026 16:17:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No