Attention is currently required from: fixeria.

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email )

Change subject: nokia: make Rx diversity configurable ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/90b2e41d_985e8025?usp=... : PS1, Line 487: bts->type != GSM_BTS_TYPE_NOKIA_SITE

Is this parameter Nokia *Site specific?

It is specific to Nokia BTS family, although not just the Site subfamily.

If not, better use `!is_nokia_bts(bts)` here like other VTY commands do.

Argh, I copied the code from `skip-reset` setting, which just happens to use direct comparison while all others use `is_nokia_bts()` as you point out. I will respin this patch, and maybe add one to make `skip-reset` setting consistent with the others.