Attention is currently required from: fixeria.

View Change

1 comment:

• File src/osmo-bsc/bts_vty.c:

  • Patch Set #1, Line 487: bts->type != GSM_BTS_TYPE_NOKIA_SITE

    Is this parameter Nokia *Site specific?

    
    It is specific to Nokia BTS family, although not just the Site subfamily.

    If not, better use `!is_nokia_bts(bts)` here like other VTY commands do.

    
    Argh, I copied the code from `skip-reset` setting, which just happens to use direct comparison while all others use `is_nokia_bts()` as you point out. I will respin this patch, and maybe add one to make `skip-reset` setting consistent with the others.

To view, visit change 42714. To unsubscribe, or for help writing mail filters, visit settings.