Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39621?usp=email ) Change subject: tests: add unit tests for osmo_rtp2trau() ...................................................................... Patch Set 1: (1 comment) File tests/trau_conv/tw5reader.c: https://gerrit.osmocom.org/c/libosmo-abis/+/39621/comment/f5fc0d0c_b78a0c36?... : PS1, Line 37: int twts005_read_frame(FILE *hexf, unsigned *lineno, uint8_t *frame,

In case you don't know about it, you may want to have a look at osmo_hexparse(). I am aware of that libosmocore function and have used it in other similar unit tests. However, in the present case because I am reading not just any hex format but specifically TW-TS-005 (besides just saying "it is hex", the spec defines maximum line length and NULL representation for 0-length RTP payloads), it was easier to copy/adapt the existing TW-TS-005 reader module/function from `gsm-codec-lib` than to reimplement a new one using `osmo_hexparse()`.

-- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia5ca8af6bd3a899253bbcc718b70e43f2265b495 Gerrit-Change-Number: 39621 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 18:58:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>