Attention is currently required from: pespin.

View Change

1 comment:

• File tests/trau_conv/tw5reader.c:

  • Patch Set #1, Line 37: int twts005_read_frame(FILE *hexf, unsigned *lineno, uint8_t *frame,

    In case you don't know about it, you may want to have a look at osmo_hexparse().

    I am aware of that libosmocore function and have used it in other similar unit tests. However, in the present case because I am reading not just any hex format but specifically TW-TS-005 (besides just saying "it is hex", the spec defines maximum line length and NULL representation for 0-length RTP payloads), it was easier to copy/adapt the existing TW-TS-005 reader module/function from `gsm-codec-lib` than to reimplement a new one using `osmo_hexparse()`.

To view, visit change 39621. To unsubscribe, or for help writing mail filters, visit settings.