Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43869?usp=email ) Change subject: saip/personalization: add SUCI parameters for SAIP 2.1 (GFM) ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43869/comment/badf18ef_e5ab76f3?usp=ema... : PS1, Line 1418: if cmd == 'filePath': : path_match = (arg == file_path) : if not path_match: : creating_fid = False : elif path_match and cmd == 'createFCP': : creating_fid = (arg.get('fileID') == ef_fid) : if creating_fid: : if first is None: : first = idx : last = idx : first = min(first, idx) : last = max(last, idx) why are we hand-rolling a decoder for the path based on the raw asn1-decoder contents, if each ProfileElementGFM instance is already maintaining a self.files[path_str] data structure? Also, for the entire ProfileElementSequence there is already a ProfileElementSequence.mf.lookup_by_path() method as well as a lookup_by_fidpath() method. IF there are shortcomings in those generig high-level methods/data structures they should be fixed, rather than reinventing parts here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b69debf5992aa715171b43b30864dc152dc556f Gerrit-Change-Number: 43869 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 14:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes