Attention is currently required from: neels.

Patch set 1:Code-Review -1

View Change

1 comment:

• File pySim/esim/saip/personalization.py:

  • Patch Set #1, Line 1418:

                   if cmd == 'filePath':
                        path_match = (arg == file_path)
                        if not path_match:
                            creating_fid = False
                    elif path_match and cmd == 'createFCP':
                        creating_fid = (arg.get('fileID') == ef_fid)
                    if creating_fid:
                        if first is None:
                            first = idx
                            last = idx
                        first = min(first, idx)
                        last = max(last, idx)
    

    why are we hand-rolling a decoder for the path based on the raw asn1-decoder contents, if each ProfileElementGFM instance is already maintaining a self.files[path_str] data structure? Also, for the entire ProfileElementSequence there is already a ProfileElementSequence.mf.lookup_by_path() method as well as a lookup_by_fidpath() method.

    IF there are shortcomings in those generig high-level methods/data structures they should be fixed, rather than reinventing parts here.

To view, visit change 43869. To unsubscribe, or for help writing mail filters, visit settings.