Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27392 ) Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate() ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/27392/comment/19b735ca_e3e9e5c9 PS1, Line 19: since osmo-mgw offers conversion between the payload type format it I think it's important to grasp from here that we use that here for AMR specificly now, but in fact it's a generic improvement: First try to select an exact codec match, otherwise try to find a suitable transcoding method (in this this case AMR OA<->BE). File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/c/osmo-mgw/+/27392/comment/c4d7ae31_39bd7fd0 PS1, Line 369: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b, bool match_pload_fmt) I'd make this more generic: bool allow_transcoding It's to be used the opposite way true/false as you are using it now. https://gerrit.osmocom.org/c/osmo-mgw/+/27392/comment/7ca435b5_43b5646c PS1, Line 431: /* In case we weren't able to find an exact match, we will try to find a match that is the same codec, but the Make all this generic. Either match codec exactly, or pick one up requiring some sort of translating/transcoding. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27392 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifbd201a2749009a4644a29bd77e1d0fc0c124a9d Gerrit-Change-Number: 27392 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 03 Mar 2022 14:45:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment