Attention is currently required from: dexter.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 19: since osmo-mgw offers conversion between the payload type format it

    I think it's important to grasp from here that we use that here for AMR specificly now, but in fact it's a generic improvement: First try to select an exact codec match, otherwise try to find a suitable transcoding method (in this this case AMR OA<->BE).

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #1, Line 369: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b, bool match_pload_fmt)

    I'd make this more generic: bool allow_transcoding
    It's to be used the opposite way true/false as you are using it now.

  • Patch Set #1, Line 431: /* In case we weren't able to find an exact match, we will try to find a match that is the same codec, but the

    Make all this generic. Either match codec exactly, or pick one up requiring some sort of translating/transcoding.

To view, visit change 27392. To unsubscribe, or for help writing mail filters, visit settings.