Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email )
Change subject: soft_uart: implement modem status lines and flow control
......................................................................
Patch Set 2:
(3 comments)
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/2af2c744_ca5f6d25
PS2, Line 398: if (active) /* assert the given line */
This might be just me, but I always associate assert with assert(), as in crash the
program here if the condition is not met. Maybe consider changing the wording here? (also
"de-asserted" above)
https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/50b33c0c_671eb795
PS2, Line 403: if (cfg->status_change_cb != NULL) {
call osmo_soft_uart_set_status instead?
File tests/soft_uart/soft_uart_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/2fc0ccab_7e234a21
PS2, Line 409: printf("expecting osmo_soft_uart_tx_ubits() to yeild
nothing\n");
yeild -> yield? same below a couple of times
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I26b93ce76f2f6b6fbf017f2684312007db3c6d48
Gerrit-Change-Number: 35172
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Nov 2023 08:56:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment