Attention is currently required from: fixeria, laforge.

View Change

3 comments:

• File src/core/soft_uart.c:

  • Patch Set #2, Line 398: if (active) /* assert the given line */

    This might be just me, but I always associate assert with assert(), as in crash the program here if the condition is not met. Maybe consider changing the wording here? (also "de-asserted" above)

  • Patch Set #2, Line 403: if (cfg->status_change_cb != NULL) {

    call osmo_soft_uart_set_status instead?

• File tests/soft_uart/soft_uart_test.c:

  • Patch Set #2, Line 409: printf("expecting osmo_soft_uart_tx_ubits() to yeild nothing\n");

    yeild -> yield? same below a couple of times

To view, visit change 35172. To unsubscribe, or for help writing mail filters, visit settings.