Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email ) Change subject: ara_m: use class byte of current lchan ...................................................................... Patch Set 8: Code-Review-1 (1 comment) Patchset: PS6:

Ok, I was mistaken (was recalling this from memory). MANAGE CHANNEL is not affected. […] I saw there's v8 of the patch, but it doesn't address this. If I look at one example (pySim/commands.py: terminal_profile), then it uses send_apdu_checksw which currently forces CLA to 0x80. With your patch applied, apply_lchan would be implicitly true and hence cause a bug.

That's why I wrote we need to make sure all commands that do not work over logical channels need to be changed to include that explicit apply_lchan=False -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2024 14:18:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: dexter <pmaier@sysmocom.de>