Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )

Change subject: ara_m: use class byte of current lchan ......................................................................

Patch Set 8: Code-Review-1

(1 comment)

Patchset:

PS6:

Ok, I was mistaken (was recalling this from memory). MANAGE CHANNEL is not affected. […]

I saw there's v8 of the patch, but it doesn't address this. If I look at one example (pySim/commands.py: terminal_profile), then it uses send_apdu_checksw which currently forces CLA to 0x80. With your patch applied, apply_lchan would be implicitly true and hence cause a bug.

That's why I wrote we need to make sure all commands that do not work over logical channels need to be changed to include that explicit apply_lchan=False