Attention is currently required from: dexter, fixeria.
Patch set 8:Code-Review -1
1 comment:
Patchset:
Ok, I was mistaken (was recalling this from memory). MANAGE CHANNEL is not affected. […]
I saw there's v8 of the patch, but it doesn't address this. If I look at one example (pySim/commands.py: terminal_profile), then it uses send_apdu_checksw which currently forces CLA to 0x80. With your patch applied, apply_lchan would be implicitly true and hence cause a bug.
That's why I wrote we need to make sure all commands that do not work over logical channels need to be changed to include that explicit apply_lchan=False
To view, visit change 37840. To unsubscribe, or for help writing mail filters, visit settings.