Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36980?usp=email ) Change subject: dissector: add support for sim polarity ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS3: fine with me, but worth fixing the cosmetics. mixing tabs with spaces is a bad idea, not just in python. File contrib/simtrace.lua: https://gerrit.osmocom.org/c/simtrace2/+/36980/comment/8a36cd95_66f9a939 PS3, Line 222: if payload_data:len() >= 4 then : subtree:add(hf_cemu_cfg_slot_mux_nr, payload_data(4,1)); : end : if payload_data:len() >= 5 then : local pres = payload_data(5,1):le_uint(); : subtree:add(hf_cemu_cfg_presence_polarity, payload_data(5,1)); : headerSubtree:add(CEMU_CONFIG_PRES_POL_PRES_H, pres) : headerSubtree:add(CEMU_CONFIG_PRES_POL_VALID, pres) : end this looks a bit like the original file used space-only indents but you're using tabs now? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If3ae350d0f4d737bc9e80c4f5d73cc1a39d076af Gerrit-Change-Number: 36980 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 04 Jun 2024 13:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment