Attention is currently required from: lynxis lazus.

Patch set 3:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #3:

    fine with me, but worth fixing the cosmetics. mixing tabs with spaces is a bad idea, not just in python.

• File contrib/simtrace.lua:

  • Patch Set #3, Line 222:

     if payload_data:len() >= 4 then
    	subtree:add(hf_cemu_cfg_slot_mux_nr, payload_data(4,1));
      end
      if payload_data:len() >= 5 then
    	local pres =  payload_data(5,1):le_uint();
        subtree:add(hf_cemu_cfg_presence_polarity, payload_data(5,1));
    	headerSubtree:add(CEMU_CONFIG_PRES_POL_PRES_H, pres)
    	headerSubtree:add(CEMU_CONFIG_PRES_POL_VALID, pres)
      end
    

    this looks a bit like the original file used space-only indents but you're using tabs now?

To view, visit change 36980. To unsubscribe, or for help writing mail filters, visit settings.