Change in osmocom-bb[master]: layer23/sysinfo: implement decoding of SI13 Rest Octets
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 ) Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ...................................................................... Patch Set 4: (1 comment) File src/host/layer23/include/osmocom/bb/common/sysinfo.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/a295f2b8_991af10d PS2, Line 74: uint8_t supported;
Yes, but <stdbool.h> in not used this file.
Add a line #include <stdbool.h> :)
The existing fields are using uint8_t for boolean logic. Yes, which is confusing to the user/reader of the code, since it's not clear what those hold (I was not sure what the uint8_t si* fields contains until I looked deeply in the code).
So I'd better stay consistent. This is not critical, right?
I'd favour using bool wherever possible, makes everyone's life easier to understand how to fill/read the structs rather than having to look to existing code which integer values are expected. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Gerrit-Change-Number: 30812 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Jan 2023 16:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
pespin