Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email ) Change subject: oml: ipacc: send GPRS Cell attributes based on IPA Object Version ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34298/comment/9e3c29c1_064de6bb PS3, Line 262: if (is_osmobts(bts) || cell->mo.ipaccess.obj_version >= 4) { I'd prefer having an explicit check for nanobts here, even if it may actually not be needed: "||(is_nanobts(bts) && cell->mo.ipaccess.obj_version >= 4)" It is easier for users to understand what this obj_version check is about (nanobts). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie0fb3eaf76e1f70e5a19bb088e1674b7e553d32a Gerrit-Change-Number: 34298 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 11 Sep 2023 22:42:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment