Attention is currently required from: Pablo Neira Ayuso, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/26990 ) Change subject: fix some cases of rc == 0 on error ...................................................................... Patch Set 1: (3 comments) Patchset: PS1:

it might be worth looking at how other code using libmnl is doing this. […] it is clear that checking errno works well. just seems weird to me to return zero on some errors while others return nonzero.

PS1: I'm not sure that it is the right thing to submit this patch. I think it makes better code, but maybe not worthwhile to change a running system. I submitted this patch mainly to let review decide whether it is any good. File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/26990/comment/e3535927_d8978396 PS1, Line 82: return -2;

or perhaps: […] just above this bit of code, the code returns -1. I thought, return -1 as well vs return a different constant. So, arbitrarily, I picked the different constant, next after -1 is -2.

I'd also just return rc, but that seems not to be intended? -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/26990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I22fd69709e023572c6c616a4184340a554456faf Gerrit-Change-Number: 26990 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pablo@gnumonks.org> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: Pablo Neira Ayuso <pablo@gnumonks.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Feb 2022 21:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment