Attention is currently required from: Pablo Neira Ayuso, laforge, pespin.
3 comments:
Patchset:
it might be worth looking at how other code using libmnl is doing this. […]
it is clear that checking errno works well.
just seems weird to me to return zero on some errors while others return nonzero.
I'm not sure that it is the right thing to submit this patch.
I think it makes better code, but maybe not worthwhile to change a running system.
I submitted this patch mainly to let review decide whether it is any good.
File src/gtp-genl.c:
Patch Set #1, Line 82: return -2;
or perhaps: […]
just above this bit of code, the code returns -1.
I thought, return -1 as well vs return a different constant.
So, arbitrarily, I picked the different constant, next after -1 is -2.
I'd also just return rc, but that seems not to be intended?
To view, visit change 26990. To unsubscribe, or for help writing mail filters, visit settings.