Attention is currently required from: daniel, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33687 ) Change subject: cosmetic: Fix doc comment ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/33687/comment/442932e3_a106a608 PS3, Line 536: * \param[in] iofd the file descriptor

Shouldn't this be \param[out]? IMHO it's something you as a caller pass in. "out" would be used in situations where you'd pass in a pre-allocated buffer that gets filled by the function, or a pointer-to-a-pointer which gets set by the function. In case of doubt, we can also not specify a direction, FYI

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec614004a0382534f4bfcc375f4d89192d7f27aa Gerrit-Change-Number: 33687 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: dexter <pmaier@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 11:06:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier@sysmocom.de> Gerrit-MessageType: comment