Attention is currently required from: daniel, dexter.

Patch set 3:Code-Review +1

View Change

1 comment:

• File src/core/osmo_io.c:

  • Patch Set #3, Line 536: * \param[in] iofd the file descriptor

    Shouldn't this be \param[out]?

    IMHO it's something you as a caller pass in. "out" would be used in situations where you'd pass in a pre-allocated buffer that gets filled by the function, or a pointer-to-a-pointer which gets set by the function. In case of doubt, we can also not specify a direction, FYI

To view, visit change 33687. To unsubscribe, or for help writing mail filters, visit settings.