Attention is currently required from: jolly.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32931 )

Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008 ......................................................................

Patch Set 1: Code-Review-1

(10 comments)

File include/osmocom/gsm/gsm0808_utils.h:

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/f17a296a_ce6f6632 PS1, Line 33: #include <sys/socket.h> This change removing struct sockaddr_storage; and adding sys/socket.h seems totally unrelated. Please do so in a separate patch.

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/b43a96cb_9c5bc514 PS1, Line 139: struct gsm0808_cell_id_list2 cil; spaces above but a tab here to separate type from name. Pick one.

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/9ad93a1b_29559b97 PS1, Line 151: GSM0808_TALKER_NORMAL_PRIORITY = 0x00, GSM0808_TALKER_PRIORITY_NORMAL, GSM0808_TALKER_PRIORITY_PRIVILEGED GSM0808_TALKER_PRIORITY_EMERGENCY

File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/178d23c7_81e00bdb PS1, Line 2231: osmo_store32be(gc->callref << 5, ptr); looks like we want some sort of packed struct here to avoid doing all this mangling? :D

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/72830af5_172b20b9 PS1, Line 2255: gc->sf = (elem[3] >> 4) & 0x1; packed struct?

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/6843cfa9_7767ff5e PS1, Line 2281: ptr[0] = pri->pci << 6; packed struct?

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/59ae9346_87841866 PS1, Line 2303: pri->pci = (elem[0] >> 6) & 0x1; packed struct?

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/4bd6c9db_ec3086bf PS1, Line 2329: ptr[0] = ff->tcp << 4; packed struct?

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/fa9c33e7_f2ead6ac PS1, Line 2352: ff->tcp = (elem[0] >> 4) & 0x1; packed struct?

https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/6131ff85_8746afeb PS1, Line 2517: *ci = osmo_load32le(elem); "le"? are you sure? usually it's "be"