Attention is currently required from: jolly.

Patch set 1:Code-Review -1

View Change

10 comments:

• File include/osmocom/gsm/gsm0808_utils.h:

  • Patch Set #1, Line 33: #include <sys/socket.h>

    This change removing struct sockaddr_storage; and adding sys/socket.h seems totally unrelated. Please do so in a separate patch.

  • Patch Set #1, Line 139: struct gsm0808_cell_id_list2 cil;

    spaces above but a tab here to separate type from name. Pick one.

  • Patch Set #1, Line 151: GSM0808_TALKER_NORMAL_PRIORITY = 0x00,

    GSM0808_TALKER_PRIORITY_NORMAL,
    GSM0808_TALKER_PRIORITY_PRIVILEGED
    GSM0808_TALKER_PRIORITY_EMERGENCY

• File src/gsm/gsm0808_utils.c:

  • Patch Set #1, Line 2231: osmo_store32be(gc->callref << 5, ptr);

    looks like we want some sort of packed struct here to avoid doing all this mangling? :D

  • Patch Set #1, Line 2255: gc->sf = (elem[3] >> 4) & 0x1;

    packed struct?

  • Patch Set #1, Line 2281: ptr[0] = pri->pci << 6;

    packed struct?

  • Patch Set #1, Line 2303: pri->pci = (elem[0] >> 6) & 0x1;

    packed struct?

  • Patch Set #1, Line 2329: ptr[0] = ff->tcp << 4;

    packed struct?

  • Patch Set #1, Line 2352: ff->tcp = (elem[0] >> 4) & 0x1;

    packed struct?

  • Patch Set #1, Line 2517: *ci = osmo_load32le(elem);

    "le"? are you sure? usually it's "be"

To view, visit change 32931. To unsubscribe, or for help writing mail filters, visit settings.