Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39714?usp=email )

Change subject: mgw: Early reject CRCX with X-Osmux if disabled by config
......................................................................


Patch Set 1:

(1 comment)

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39714/comment/58e3b093_59c09a04?usp=email :
PS1, Line 898: 		rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX));
> IMHO it still makes more sense to move it to the `/* Reject non-osmux if required by config */` case […]
Leaving it here:
- Keeps old behavior, so no extra changes
- Despite the description/naming of the counter being wrong, it still keeps the consistent behavior in all code paths being ticket (basically client requesting Osmux but mgw failing for wahtever reason).

So I really think it makes more sense to leave it here, will make follow-up fixing a bit less traumatic, by simply renaming this counter and adding another one (called like this one now) on the other case.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39714?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0245b6c02bf7a3452532e8bf0d7c33479999ce9f
Gerrit-Change-Number: 39714
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Mar 2025 13:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>