Attention is currently required from: osmith.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #1, Line 898: rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX));

    IMHO it still makes more sense to move it to the `/* Reject non-osmux if required by config */` case […]

    Leaving it here:

    • Keeps old behavior, so no extra changes
    • Despite the description/naming of the counter being wrong, it still keeps the consistent behavior in all code paths being ticket (basically client requesting Osmux but mgw failing for wahtever reason).

    So I really think it makes more sense to leave it here, will make follow-up fixing a bit less traumatic, by simply renaming this counter and adding another one (called like this one now) on the other case.

To view, visit change 39714. To unsubscribe, or for help writing mail filters, visit settings.