Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30266 ) Change subject: paging: Store list of gsm_paging_request in bsc_subscr ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File include/osmocom/bsc/bsc_subscriber.h: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/31bf702f_191234a0 PS2, Line 57: gsm_paging_request IMO, it's better to have all forward declarations in one place (above). File src/osmo-bsc/bsc_subscriber.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/a4eb5358_45ada17f PS3, Line 270: it could be freed during put(): JFYI: the usual way to avoid this is would be: { bsc_subscr_get(bsub, __func__); /* ... function body ... */ bsc_subscr_put(bsub, __func__); } File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30266/comment/397aba2a_c5775cee PS3, Line 533: it could be freed during put(): Same here, doing get(__func__) .. put(__func__) would be cleaner. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I831d0fe01d7812c34500362b90f47cd65645b666 Gerrit-Change-Number: 30266 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 18:19:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment