Attention is currently required from: pespin.

Patch set 3:Code-Review +1

View Change

3 comments:

• File include/osmocom/bsc/bsc_subscriber.h:

  • Patch Set #2, Line 57: gsm_paging_request

    IMO, it's better to have all forward declarations in one place (above).

• File src/osmo-bsc/bsc_subscriber.c:

  • Patch Set #3, Line 270: it could be freed during put():

    JFYI: the usual way to avoid this is would be:

      {
        bsc_subscr_get(bsub, __func__);

        /* ... function body ... */

        bsc_subscr_put(bsub, __func__);
      }

• File src/osmo-bsc/paging.c:

  • Patch Set #3, Line 533: it could be freed during put():

    Same here, doing get(__func__) .. put(__func__) would be cleaner.

To view, visit change 30266. To unsubscribe, or for help writing mail filters, visit settings.