Attention is currently required from: jolly, laforge.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43043?usp=email )
Change subject: V1.2: Add function ES10b.EnableEmergencyProfile ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File include/onomondo/ipa/ipad.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/cccb1cba_04d54c4b?... : PS3, Line 99: int ipa_enable_emergency_profile(struct ipa_context *ctx); you can shorten "profile" to "prfle", we used this abbreviation in lots of other places too.
File src/ipa/libipa/es10b_en_emerg_prfle.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/db204658_4793ada0?... : PS3, Line 14: struct EnableEmergencyProfileResponse *res; Also here, it is just an integer that is returned, maybe return it directly to get an API that is simpler to use?
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43043/comment/39d88b30_0e485d3f?... : PS3, Line 179: { "enable-emergency-profile", no_argument, NULL, OPT_ENABLEEMGERGENCY}, See comment from @laforge@gnumonks.org in the previous patch. I think we should clean this up.
-
dexter