Attention is currently required from: jolly, laforge.

Patch set 3:Code-Review +1

View Change

3 comments:

• File include/onomondo/ipa/ipad.h:

  • Patch Set #3, Line 99: int ipa_enable_emergency_profile(struct ipa_context *ctx);

    you can shorten "profile" to "prfle", we used this abbreviation in lots of other places too.

• File src/ipa/libipa/es10b_en_emerg_prfle.h:

  • Patch Set #3, Line 14: struct EnableEmergencyProfileResponse *res;

    Also here, it is just an integer that is returned, maybe return it directly to get an API that is simpler to use?

• File src/ipa/main.c:

  • Patch Set #3, Line 179: { "enable-emergency-profile", no_argument, NULL, OPT_ENABLEEMGERGENCY},

    See comment from @laforge@gnumonks.org in the previous patch. I think we should clean this up.

To view, visit change 43043. To unsubscribe, or for help writing mail filters, visit settings.