Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 1: (5 comments) File library/Osmocom_VTY_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/3b9498ad_d441b... PS1, Line 247: type record of charstring StrList; You may be probably reusing this for something no VTY related? then maybe move it to another module actually aimed at providing types? File library/PFCP_CodecPort_CtrlFunct.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/98d16bbb_a6a2a... PS1, Line 7: inout PFCP_PT portRef, did you copy this? indentation looks weird. File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/1368050c_8d560... PS1, Line 18: type enumerated e_PFCP_Cause { You could move some of these into PFCP_Types.ttcn https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/79d5a3d0_ec6f5... PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP { Please improve the scope of template types. ts_* -> "template (value)" tr_* -> "template (present)" https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/5a13e485_f1063... PS1, Line 460: function tr_PFCP_Session_Est_Resp(template OCT8 hdr_seid := ?) return template PDU_PFCP { template (present) OCT8 hdr_seid -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Wed, 27 Jul 2022 14:48:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment