Attention is currently required from: neels.

View Change

5 comments:

• File library/Osmocom_VTY_Functions.ttcn:

  • Patch Set #1, Line 247: type record of charstring StrList;

    You may be probably reusing this for something no VTY related? then maybe move it to another module actually aimed at providing types?

• File library/PFCP_CodecPort_CtrlFunct.ttcn:

  • Patch Set #1, Line 7: inout PFCP_PT portRef,

    did you copy this? indentation looks weird.

• File library/PFCP_Templates.ttcn:

  • Patch Set #1, Line 18: type enumerated e_PFCP_Cause {

    You could move some of these into PFCP_Types.ttcn

  • Patch Set #1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP {

    Please improve the scope of template types.
    ts_* -> "template (value)"
    tr_* -> "template (present)"

  • Patch Set #1, Line 460: function tr_PFCP_Session_Est_Resp(template OCT8 hdr_seid := ?) return template PDU_PFCP {

    template (present) OCT8 hdr_seid

To view, visit change 28817. To unsubscribe, or for help writing mail filters, visit settings.