Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33943 ) Change subject: Added first steps towards tetra crypto support ...................................................................... Patch Set 1: (12 comments) File src/crypto/tetra_crypto.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/227e4cd5_1b634f19 PS1, Line 98: void tetra_crypto_init(); Bad function definition - void tetra_crypto_init() should probably be void tetra_crypto_init(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/4224422e_0a259b3d PS1, Line 112: void update_current_cck(); Bad function definition - void update_current_cck() should probably be void update_current_cck(void) File src/crypto/tetra_crypto.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/29f1db8b_ac8bda28 PS1, Line 46: if (tea_type > 7) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/153f6c0c_ce5e4715 PS1, Line 67: void tetra_crypto_init() Bad function definition - void tetra_crypto_init() should probably be void tetra_crypto_init(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/dd7a2431_0bb330ff PS1, Line 98: if (k->key_type & (KEYTYPE_DCK | KEYTYPE_MGCK)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/d6b92260_251f93a1 PS1, Line 101: if (k->key_type & (KEYTYPE_CCK | KEYTYPE_SCK)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/e98f2fdc_65308100 PS1, Line 106: for (int i = 0; i < 10; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/5a1efc88_338960ad PS1, Line 163: if (addr >= tcdb->ranges[i].start && addr < tcdb->ranges[i].end) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/d928f9c9_0305e15c PS1, Line 217: if (!tcs->network) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/444700d2_05f2db1b PS1, Line 223: if (is_issi(addr)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/e406ba8d_412f5db4 PS1, Line 262: void update_current_cck() Bad function definition - void update_current_cck() should probably be void update_current_cck(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057): https://gerrit.osmocom.org/c/osmo-tetra/+/33943/comment/8ba9ce29_424802cc PS1, Line 284: if (tcdb->nets[i].mcc == mcc && tcdb->nets[i].mnc == mnc) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I63bc712630ae5dbaa049c129d456f7aef5bda863 Gerrit-Change-Number: 33943 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag@midnightblue.nl> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 26 Jul 2023 15:48:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment