12 comments:
File src/crypto/tetra_crypto.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 98: void tetra_crypto_init();
Bad function definition - void tetra_crypto_init() should probably be void tetra_crypto_init(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 112: void update_current_cck();
Bad function definition - void update_current_cck() should probably be void update_current_cck(void)
File src/crypto/tetra_crypto.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 46: if (tea_type > 7) {
braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 67: void tetra_crypto_init()
Bad function definition - void tetra_crypto_init() should probably be void tetra_crypto_init(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 98: if (k->key_type & (KEYTYPE_DCK | KEYTYPE_MGCK)) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 101: if (k->key_type & (KEYTYPE_CCK | KEYTYPE_SCK)) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 106: for (int i = 0; i < 10; i++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 163: if (addr >= tcdb->ranges[i].start && addr < tcdb->ranges[i].end) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 217: if (!tcs->network) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 223: if (is_issi(addr)) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 262: void update_current_cck()
Bad function definition - void update_current_cck() should probably be void update_current_cck(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10057):
Patch Set #1, Line 284: if (tcdb->nets[i].mcc == mcc && tcdb->nets[i].mnc == mnc) {
braces {} are not necessary for single statement blocks
To view, visit change 33943. To unsubscribe, or for help writing mail filters, visit settings.