Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email ) Change subject: Gb: ensure a BSSGP Tx Status don't overflow on too big messages ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/43890/comment/9d141899_87f17cdd?u... : PS1, Line 11: TS 48.018 specifies the BSSGP layer should taken the lower layer
should take Done
File src/gb/gprs_bssgp_util.c: https://gerrit.osmocom.org/c/libosmocore/+/43890/comment/247c423a_50f64036?u... : PS1, Line 587: OSMO_MIN(msgb_bssgp_len(orig_msg), msgb_tailroom(msg) - 3),
is the 3 for T + L? Do you mind writing it in a comment? Done
File tests/gb/gprs_bssgp_test.c: https://gerrit.osmocom.org/c/libosmocore/+/43890/comment/54d24768_8590a5c6?u... : PS1, Line 293: static bool _test_bssgp_tx_status_too_big_rx = false;
This variable seems unused, only set to true and nothing more. Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I427d23887dcc05705228b553428d14fda086b06f Gerrit-Change-Number: 43890 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 14 Oct 2026 17:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>